feat(react-router): Add Experimental React Server Components (RSC) instrumentation#18882
Open
onurtemizkan wants to merge 6 commits intodevelopfrom
Open
feat(react-router): Add Experimental React Server Components (RSC) instrumentation#18882onurtemizkan wants to merge 6 commits intodevelopfrom
onurtemizkan wants to merge 6 commits intodevelopfrom
Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
159fb80 to
07fc2d6
Compare
Member
|
@onurtemizkan sorry this one went under the radar. Can you resolve the conflict and ping me again? |
07fc2d6 to
c94138a
Compare
Collaborator
Author
|
@chargome, it's ready for review 👍 |
Contributor
Codecov Results 📊Generated by Codecov Action |
chargome
reviewed
Feb 4, 2026
Member
chargome
left a comment
There was a problem hiding this comment.
Generally LGTM to me but is there a way we could already wrap the server components with vite? Also initing the Client in a hook might happen quite late – any ideas if the client will eventually support an entry file?
Comment on lines
+4
to
+8
| /** | ||
| * WeakSet to track errors that have been captured to avoid double-capture. | ||
| * Uses WeakSet so errors are automatically removed when garbage collected. | ||
| */ | ||
| const CAPTURED_ERRORS = new WeakSet<object>(); |
Member
There was a problem hiding this comment.
q: Why do we need this in here? We have a dedupe integration that should take of this I think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #17337
Adds experimental instrumentation for React Router v7.9.0+ React Server Components (RSC).
React Router's RSC support is currently behind
unstable_reactRouterRSC()and subject to change. These wrappers provide error capture and performance tracing for RSC server requests, server components, and server functions.RSC Request Handlers
Added
wrapMatchRSCServerRequest()andwrapRouteRSCServerRequest():wrapMatchRSCServerRequest- Wraps RSC server matching with spans for generateResponse and loadServerActionwrapRouteRSCServerRequest- Wraps SSR request handling with spans for fetchServer and renderHTMLServer Components
Added
wrapServerComponent()for error instrumentation:Redirect (3xx) and not-found (404) responses are not captured as errors.
Server Functions
Added
wrapServerFunction()andwrapServerFunctions()for "use server" functions:Needs docs PR